⚡ Bolt: Cache IconifyIcon resolution#46
Conversation
Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Introduced a
Map-based cache inside theiconDatafunction inclient/src/components/base/IconifyIcon.tsxto store resolved icon data objects. Also correctly caches negative results usingnull.🎯 Why: Previously, every render of
IconifyIconrequired iterating over an array of 10+ icon sets and splitting strings. For applications that heavily utilize UI icons, thisO(N)loop operation runs frequently and blocks the React render cycle, severely penalizing performance on pages with many icons.📊 Impact: Reduces array iterations for icon lookups from
O(N)toO(1)per repeated render, significantly eliminating render blocking for pages heavy on Material UI icons.🔬 Measurement: Verifiable via React Profiler. Render times of components with multiple
IconifyIcondescendants will noticeably decrease. Verified safe behavior viapnpm lintandpnpm build. Added a learning to.jules/bolt.md.PR created automatically by Jules for task 56772821907501021 started by @sshahriazz